replace strncmp calls with static size, replace single char compare#81
Open
Jan200101 wants to merge 1 commit into13-CF:masterfrom
Open
replace strncmp calls with static size, replace single char compare#81Jan200101 wants to merge 1 commit into13-CF:masterfrom
Jan200101 wants to merge 1 commit into13-CF:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calls like
strncmp(osname, "Alpine Linux", 12)end up being more work than they are worth and getting the length of the const string should be gathered at compile time.instances of strncmp with a size of 1 were simple replace with a compare, if the logic around it ensures that the pointer will not be out of bounds.